C++Talk.NET

Matthew D Moss · Guest

I'm porting our codebase to a new platform using a build of gcc 4.0.2.
Currently, it compiles under a build of gcc 2.95 and a couple Microsoft
compilers

I'm not sure what the standard makes of the code below; trying to
figure that out now. This code is our own enhanced version of printf;
does type-checking, etc. I didn't write this code here, just trying to
port it, and gcc 4.0.2 is giving me the following error:

foo.cpp: In function 'void bar(int)':
foo.h:46: error: too many arguments to function 'const char*
MakeString(const char*)'
foo.cpp:246: error: at this point in file

Can someone give me a hint, or pointer into the standard, or
explanation of the problem? The older compilers find MakeString(const
char* fmt, T1 t1) just fine, but as I've been finding out, gcc 4.0.2
seems to be stricter in compliance.

Thanks....

// foo.h
class FormatString
{
public:
FormatString(const char* fmt);
FormatString& operator << (int);
FormatString& operator << (const char*);
// etc...
const char* Str();
};

inline const char* MakeString(const char* fmt) // LINE 46
{
FormatString f(fmt);
return f.Str();
}

template<class T1>
const char* MakeString(const char* fmt, T1 t1)
{
FormatString f(fmt);
f << t1;
return f.Str();
}

template<class T1, class T2>
const char* MakeString(const char* fmt, T1 t1, T2 t2)
{
FormatString f(fmt);
f << t1 << t2;
return f.Str();
}

// etc, more versions of MakeString with more parameters

// foo.cpp
void bar(int k)
{
Log << MakeString("Max value is %d\n", k); // LINE 246
}

[ See http://www.gotw.ca/resources/clcm.htm for info about ]
[ comp.lang.c++.moderated. First time posters: Do this! ]

Thomas Tutone · Guest

Matthew D Moss wrote:

Matthew D Moss · Guest

Turns out I was missing the appropriate FormatString::operator<< for
the actual type being passed into MakeString. (My example showed an int
to simplify the code, but it was actually an enum.)

Typecasting the enum to an int allowed the template function to be
found.

Although I guess I'm wondering whether that's just a misunderstanding
on my part (of the error msg), a misleading error msg, or something
really broken.

I can't really upgrade from 4.0.2 right at this moment... but thanks
for the mention about that version. I may look to see if our provider
is going to move up.

[ See http://www.gotw.ca/resources/clcm.htm for info about ]
[ comp.lang.c++.moderated. First time posters: Do this! ]

Earl Purple · Guest

Matthew D Moss wrote:

Matthew D Moss · Guest