C++Talk.NET Forum Index C++Talk.NET
C++ language newsgroups
 
Archives   FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Problems initializing a dynamically allocated 2D array

 
Post new topic   Reply to topic    C++Talk.NET Forum Index -> C++ language (comp.lang.c++)
View previous topic :: View next topic  
Author Message
masood.iqbal@lycos.com
Guest
PostPosted: Sun Jan 30, 2005 2:51 pm    Post subject: Problems initializing a dynamically allocated 2D array Reply with quote


I am having lots of trouble getting a simple program that initializs a
dynamically allocated 2D array to work. My 2D array is not getting
initialized properly, and additionally I am getting a "Null pointer
assignment" error. Kindly help.

Also, eventually I intend to move this logic to a separate function.
For that, I believe, that I will need to pass a
pointer-to-pointer-to-pointer type as an arguent. Please confirm.

[My apologies to C purists --- I am using the new operator instead of
malloc/calloc since I find its usage more intuitive]

Masood



/************************************************************************/
#include <stdio.h>

#define ROWS 3
#define COLUMNS 5


main()
{
int **tbl;
size_t rows = ROWS;
size_t cols = COLUMNS;
int startVal = 2;

tbl = new (int**)[cols];

for(size_t i = 0; i < rows; i++)
tbl[i] = new (int *)[rows];

for(size_t i1 = 0; i1 < rows; i1++)
for(size_t j1 = 0; j1 < cols; j1++)
tbl[i1][j1] = startVal++;

for(size_t i2 = 0; i2 < rows; i2++)
for(size_t j2 = 0; j2 < cols; j2++)
printf("Row: %d, Col: %d => %dn",
i2, j2, tbl[i2][j2]);
return 0;
}

Back to top
Alf P. Steinbach
Guest
PostPosted: Sun Jan 30, 2005 3:15 pm    Post subject: Re: Problems initializing a dynamically allocated 2D array Reply with quote


* [email]masood.iqbal (AT) lycos (DOT) com[/email]:
Quote:
[Cross-posted to C and C++ newsgroups, Not a Good Idea]

Please don't do that
(except where it is an issue of interest to practitioners of both).

Follow-up set to [comp.lang.c++].


* [email]masood.iqbal (AT) lycos (DOT) com[/email]:
Quote:
I am having lots of trouble getting a simple program that initializs a
dynamically allocated 2D array to work. My 2D array is not getting
initialized properly, and additionally I am getting a "Null pointer
assignment" error. Kindly help.

Don't use raw pointers.

Use standard containers like e.g. std::vector.

Then all your current problems disappear.



Quote:
Also, eventually I intend to move this logic to a separate function.
For that, I believe, that I will need to pass a
pointer-to-pointer-to-pointer type as an arguent. Please confirm.

Pass a reference to the container.


Quote:
[My apologies to C purists --- I am using the new operator instead of
malloc/calloc since I find its usage more intuitive]

Using 'new' is a good idea when you really need to handle allocation
yourself.

Here you _don't_ need to handle allocation yourself.

Use standard containers like e.g. std::vector.



Quote:
/************************************************************************/
#include <stdio.h

#define ROWS 3
#define COLUMNS 5

Preferentially use constants, like e.g.

std::size_t const nRows = 3;
std::size_t const nColumns = 5;


Quote:
main()

Must have 'int' return value type, both in C and C++.


Quote:
{
int **tbl;

Indentation.


Quote:
size_t rows = ROWS;
size_t cols = COLUMNS;

Those should be 'const' (already mentioned).


Quote:
int startVal = 2;

tbl = new (int**)[cols];

tbl = new (int*)[cols];


Quote:
for(size_t i = 0; i < rows; i++)
tbl[i] = new (int *)[rows];

tbl[i] = new int[rows];


Quote:
for(size_t i1 = 0; i1 < rows; i1++)

It's a good idea to use meaningful names, e.g. 'iRow'.

Preferentially use '++i', not 'i++'.

See
http://home.no.net/dubjai/win32cpptut/html/w32cpptut_01_02_11.html>.
<url:
http://www.parashift.com/c++-faq-lite/operator-overloading.html#faq-13.11>
<url:
http://www.parashift.com/c++-faq-lite/operator-overloading.html#faq-13.12>


Quote:
for(size_t j1 = 0; j1 < cols; j1++)
tbl[i1][j1] = startVal++;

If you had used meaningful names this would have been

tbl[iRow][iColumn] = ++startVal;

which hopefully you can see is incorrect (which index goes where?).


Quote:
for(size_t i2 = 0; i2 < rows; i2++)
for(size_t j2 = 0; j2 < cols; j2++)
printf("Row: %d, Col: %d => %dn",
i2, j2, tbl[i2][j2]);
return 0;
}


Use standard containers like e.g. std::vector.

--
A: Because it messes up the order in which people normally read text.
Q: Why is it such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?

Back to top
ajk
Guest
PostPosted: Sun Jan 30, 2005 3:30 pm    Post subject: Re: Problems initializing a dynamically allocated 2D array Reply with quote


On 30 Jan 2005 06:51:05 -0800, [email]masood.iqbal (AT) lycos (DOT) com[/email] wrote:

Quote:
main()
{
int **tbl;
size_t rows = ROWS;
size_t cols = COLUMNS;
int startVal = 2;

tbl = new (int**)[cols]; // ok here allocate tbl[0..4]

for(size_t i = 0; i < rows; i++)
tbl[i] = new (int *)[rows]; // tbl[0..4] = int array [0..2] ok

for(size_t i1 = 0; i1 < rows; i1++)
for(size_t j1 = 0; j1 < cols; j1++) // now you are turning it around
tbl[i1][j1] = startVal++; // tbl[0..2][0..4] .. not good

for(size_t i2 = 0; i2 < rows; i2++)
for(size_t j2 = 0; j2 < cols; j2++)
printf("Row: %d, Col: %d => %dn",
i2, j2, tbl[i2][j2]); // tbl[0..2][0..4] also not good.
return 0;
}

hth/ak

--
"Those are my principles. If you don't like them I have others."
Groucho Marx.

Back to top
Gianni Mariani
Guest
PostPosted: Sun Jan 30, 2005 3:52 pm    Post subject: Re: Problems initializing a dynamically allocated 2D array Reply with quote
[email]masood.iqbal (AT) lycos (DOT) com[/email] wrote:
Quote:
I am having lots of trouble getting a simple program that initializs a
dynamically allocated 2D array to work. My 2D array is not getting
initialized properly, and additionally I am getting a "Null pointer
assignment" error. Kindly help.

Use a matrix class ... this is just an example (although it works) -
there are some extensive matrix libraries you could use and ones that
are very efficient if the dimensions are known.

#include <vector>

template <typename w_elem_type>
class matrix
{
public:
typedef int t_Size;

t_Size m_columns;
t_Size m_rows;

std::vector<w_elem_type> m_data;

matrix( t_Size i_columns = 0, t_Size i_rows = 0 )
: m_columns( i_columns ),
m_rows( i_rows ),
m_data( i_columns * i_rows )
{
}

w_elem_type * operator[]( t_Size i_index )
{
return & ( m_data[ i_index * m_rows ] );
}

template <typename w_Type, int w_columns, int w_rows>
matrix( const w_Type (&i_array)[w_columns][w_rows] )
: m_columns( w_columns ),
m_rows( w_rows ),
m_data( & (i_array[0][0]), & (i_array[w_columns-1][w_rows]) )
{
}

};

#include <iostream>

double array[3][4] = {
{ 1.0, 2.0, 3.3, 4.4 },
{ 1.0, 2.0, 3.3, 4.4 },
{ 1.0, 2.0, 3.3, 4.5 },

};

int main()
{
matrix<float> mat1( 3, 4 );
matrix<float> mat2;
matrix<float> mat3( array );

mat2 = mat3;

std::cout << mat2[2][3] << "n";
}

Quote:

Also, eventually I intend to move this logic to a separate function.
For that, I believe, that I will need to pass a
pointer-to-pointer-to-pointer type as an arguent. Please confirm.

If you use the martix class above, you can pass it by reference, const
reference or value.

void foo( matrix void foo( const matrix<int> & just_read_me );
void foo( const matrix<int> & make_a_copy_of_me );

Note that the matrix is parameterized on element type.

Quote:

[My apologies to C purists --- I am using the new operator instead of
malloc/calloc since I find its usage more intuitive]

Try not posting to the C groups if you're really interested in C++.

Quote:

/************************************************************************/
#include <stdio.h

#define ROWS 3
#define COLUMNS 5


main()
{
int **tbl;
size_t rows = ROWS;
size_t cols = COLUMNS;
int startVal = 2;

tbl = new (int**)[cols];

tbl = new (int*)[cols]; // this is probably what you wanted

Quote:

for(size_t i = 0; i < rows; i++)
tbl[i] = new (int *)[rows];

tbl[i] = new (int)[rows]; // again

Quote:

for(size_t i1 = 0; i1 < rows; i1++)
for(size_t j1 = 0; j1 < cols; j1++)
tbl[i1][j1] = startVal++;

tbl[j1][i1] = startVal++; // probably transposed i & j

Quote:

for(size_t i2 = 0; i2 < rows; i2++)
for(size_t j2 = 0; j2 < cols; j2++)
printf("Row: %d, Col: %d => %dn",
i2, j2, tbl[i2][j2]);

.... again transposed i and j

Quote:
return 0;
}


Back to top
CBFalconer
Guest
PostPosted: Sun Jan 30, 2005 4:03 pm    Post subject: Re: Problems initializing a dynamically allocated 2D array Reply with quote
[email]masood.iqbal (AT) lycos (DOT) com[/email] wrote:
Quote:

.... snip ...

[My apologies to C purists --- I am using the new operator instead
of malloc/calloc since I find its usage more intuitive]

There is no new operator in C.

Quote:

.... snip ...

main()

main returns int. Say so.

Quote:
{
.... snip ...

tbl = new (int**)[cols];

see above
Quote:

for(size_t i = 0; i < rows; i++)
tbl[i] = new (int *)[rows];

and see above. Try indenting your code or using a real newsreader.

In addition, do not crosspost without setting followups to one
group alone. F'ups set to the one group where it may be topical.

--
"If you want to post a followup via groups.google.com, don't use
the broken "Reply" link at the bottom of the article. Click on
"show options" at the top of the article, then click on the
"Reply" at the bottom of the article headers." - Keith Thompson



Back to top
Old Wolf
Guest
PostPosted: Sun Jan 30, 2005 7:49 pm    Post subject: Re: Problems initializing a dynamically allocated 2D array Reply with quote
[email]masood.iqbal (AT) lycos (DOT) com[/email] wrote:
Quote:
I am having lots of trouble getting a simple program that initializs
a
dynamically allocated 2D array to work. My 2D array is not getting
initialized properly, and additionally I am getting a "Null pointer
assignment" error. Kindly help.

#include <stdio.h

#define ROWS 3
#define COLUMNS 5

main()
{
int **tbl;
size_t rows = ROWS;
size_t cols = COLUMNS;
int startVal = 2;

tbl = new (int**)[cols];

Bizarre that I had never seen someone do this until yesterday,
but now I've seen it twice (it came up in another thread).
What you mean is:

.. tbl = new int*[cols];

tbl is a pointer to pointer to int. So you must create
pointer(s) to int for it to point at.

The syntax you wrote is actually illegal (Comeau C++ would have
told you that). But some compilers parse it as:

.. tbl = (new (int**))[cols]

ie. creating a new pointer to pointer to int, and then
dereferencing it (causing undefined behaviour, probably
the cause of the errors you reported).

For more information, see the thread in comp.std.c++
titled "Strange new/new() problem".


Quote:
for(size_t i = 0; i < rows; i++)
tbl[i] = new (int *)[rows];

Ditto: tbl[i] = new int[rows];

tbl[i] is a pointer to int. It points to ints.
Obviously, trying to point it to a pointer-to-int will
get you into trouble.

Quote:
for(size_t i1 = 0; i1 < rows; i1++)
for(size_t j1 = 0; j1 < cols; j1++)
tbl[i1][j1] = startVal++;

That should be tbl[j1][i1]

Remember that you created 'cols' pointers to int, and
each one points to a block of 'rows' ints.

Quote:
for(size_t i2 = 0; i2 < rows; i2++)
for(size_t j2 = 0; j2 < cols; j2++)
printf("Row: %d, Col: %d => %dn",
i2, j2, tbl[i2][j2]);

Ditto.

Quote:
return 0;

You should delete[] all of the stuff you allocated.

Quote:
}

You could have saved yourself a lot of trouble by using
a vector of vectors, instead of new and delete.


Back to top
Dave Thompson
Guest
PostPosted: Mon Feb 07, 2005 6:55 am    Post subject: Re: Problems initializing a dynamically allocated 2D array Reply with quote
On Sun, 30 Jan 2005 15:15:20 GMT, [email]alfps (AT) start (DOT) no[/email] (Alf P. Steinbach)
wrote:

Quote:
* [email]masood.iqbal (AT) lycos (DOT) com[/email]:
[Cross-posted to C and C++ newsgroups, Not a Good Idea]

Please don't do that
(except where it is an issue of interest to practitioners of both).

Follow-up set to [comp.lang.c++].

Actually they weren't. (I've made the same mistake in the past, it's

not as convenient with Agent as one might like.) <G>

<snip>
Quote:
main()

Must have 'int' return value type, both in C and C++.

In C99, and (any) C++.


<snip>
Quote:
tbl = new (int**)[cols];

tbl = new (int*)[cols];

No, that's also a (somewhat more obscure) mistake. It parses as

tbl = ( new (int*) ) [cols]
which allocates a single pointer, uninitialized, and tries to
subscript it. Except in (some versions of?) g++, which "fixes" it for
you. To be standard you want
tbl = new int * [cols];

<snip>

- David.Thompson1 at worldnet.att.net

Back to top
apoorv
Guest
PostPosted: Thu Feb 10, 2005 6:31 am    Post subject: Re: Problems initializing a dynamically allocated 2D array Reply with quote
main()
Quote:
{
int **tbl;
size_t rows = ROWS;
size_t cols = COLUMNS;
int startVal = 2;

tbl = new (int**)[cols]; // ok here allocate tbl[0..4]

for(size_t i = 0; i < cols; i++) //here is simple prob u are allocating
for cols and accessing till row??????
tbl[i] = new (int *)[rows]; // tbl[0..4] = int array [0..2]
ok

for(size_t i1 = 0; i1 < rows; i1++)
for(size_t j1 = 0; j1 < cols; j1++) // now you are turning it around
tbl[i1][j1] = startVal++; // tbl[0..2][0..4] .. not good

for(size_t i2 = 0; i2 < rows; i2++)
for(size_t j2 = 0; j2 < cols; j2++)
printf("Row: %d, Col: %d => %dn",
i2, j2, tbl[i2][j2]); // tbl[0..2][0..4] also not good.
return 0;
}




Back to top
Display posts from previous:   
Post new topic   Reply to topic    C++Talk.NET Forum Index -> C++ language (comp.lang.c++) All times are GMT
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2006 phpBB Group
SEO toolkit © 2004-2006 webmedic.